Skip to content

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Oct 25, 2024

DOC-4370

The same info applies to both Jedis and Lettuce.

@andy-stark-redis andy-stark-redis requested a review from a team October 25, 2024 13:35
@andy-stark-redis andy-stark-redis self-assigned this Oct 25, 2024
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of forced emphasis (bold face "must"), but otherwise LGTM.

@andy-stark-redis
Copy link
Contributor Author

@dwdougherty It's actually italic (which I think is slightly less intrusive than boldface), but I would generally agree with you on this. The reason I've used it here is because the new advice conflicts with the old but looks quite similar (ie, the fact that it's visually jarring draws attention to the important new info). Anyway, thanks for the approval :-)

@andy-stark-redis andy-stark-redis merged commit b37b1dc into main Oct 25, 2024
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4370-dns-cache-info branch October 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants